Skip to content

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Oct 24, 2025

The test began to fail in Ubuntu 23.10. While investigating, I found and filed two new issues:

This test fix changes setAction to addActionListener and it is to avoid problemlisting the test on Linux.

Testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316274: javax/swing/ButtonGroup/TestButtonGroupFocusTraversal.java fails in Ubuntu 23.10 with Motif LAF (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27979/head:pull/27979
$ git checkout pull/27979

Update a local copy of the PR:
$ git checkout pull/27979
$ git pull https://git.openjdk.org/jdk.git pull/27979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27979

View PR using the GUI difftool:
$ git pr show -t 27979

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27979.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316274: javax/swing/ButtonGroup/TestButtonGroupFocusTraversal.java fails in Ubuntu 23.10 with Motif LAF

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2025
Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from minor suggestions (on unchanged lines) :

  • blockTillDisplayed Ln#177 and Thread.sleep() Ln#184 can be replaced by robot.delay() for a cleaner code
  • Frame title "Test" is generic, can be changed to the test name
  • toggleButtonActionPerformed, checkboxActionPerformed volatile vars?

@azvegint
Copy link
Member Author

LGTM apart from minor suggestions (on unchanged lines) :

* blockTillDisplayed Ln#177 and Thread.sleep() Ln#184 can be replaced by robot.delay() for a cleaner code

* Frame title "Test" is generic, can be changed to the test name

* toggleButtonActionPerformed, checkboxActionPerformed volatile vars?

updated

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 25, 2025
} catch (InterruptedException e) {
e.printStackTrace();
}
robot.delay(100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails intermittently when run on local macOS (15.7.1). Increasing the delay here to 200-300ms seems to work.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2025
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

Going to push as commit d62553d.
Since your change was applied there have been 69 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2025
@openjdk openjdk bot closed this Oct 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2025
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@azvegint Pushed as commit d62553d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb
Copy link
Member

mrserb commented Oct 30, 2025

This test fix changes setAction to addActionListener and it is to avoid problemlisting the test on Linux.

Why does replacing setAction with addActionListener to make the text visible affect the test execution?

@azvegint
Copy link
Member Author

Why does replacing setAction with addActionListener to make the text visible affect the test execution?

It is not clear yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants