-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8316274: javax/swing/ButtonGroup/TestButtonGroupFocusTraversal.java fails in Ubuntu 23.10 with Motif LAF #27979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316274: javax/swing/ButtonGroup/TestButtonGroupFocusTraversal.java fails in Ubuntu 23.10 with Motif LAF #27979
Conversation
…ails in Ubuntu 23.10 with Motif LAF
|
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
|
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 68 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from minor suggestions (on unchanged lines) :
- blockTillDisplayed Ln#177 and Thread.sleep() Ln#184 can be replaced by robot.delay() for a cleaner code
- Frame title "Test" is generic, can be changed to the test name
- toggleButtonActionPerformed, checkboxActionPerformed volatile vars?
updated |
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| robot.delay(100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fails intermittently when run on local macOS (15.7.1). Increasing the delay here to 200-300ms seems to work.
|
/integrate |
|
Going to push as commit d62553d.
Your commit was automatically rebased without conflicts. |
Why does replacing setAction with addActionListener to make the text visible affect the test execution? |
It is not clear yet. |
The test began to fail in Ubuntu 23.10. While investigating, I found and filed two new issues:
e.g. setAction vs addActionListener
This test fix changes
setActiontoaddActionListenerand it is to avoid problemlisting the test on Linux.Testing looks good.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27979/head:pull/27979$ git checkout pull/27979Update a local copy of the PR:
$ git checkout pull/27979$ git pull https://git.openjdk.org/jdk.git pull/27979/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27979View PR using the GUI difftool:
$ git pr show -t 27979Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27979.diff
Using Webrev
Link to Webrev Comment